Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Stack): reduce offset y on hover #1771

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Dec 19, 2024

Closes #667

Screenshot 2024-12-19 at 13 30 43

Stand: https://nda.ya.ru/t/5RivuhTX7AXD3g
You need to turn on VDisks column (in VDisks with PDisks column and Nodes table donors now are displayed differently)

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
222 221 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 65.89 MB | Main: 65.89 MB
Diff: 0.00 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@@ -3,7 +3,7 @@
--ydb-stack-offset-x: 4px;
--ydb-stack-offset-y: 4px;
--ydb-stack-offset-x-hover: 4px;
--ydb-stack-offset-y-hover: 8px;
--ydb-stack-offset-y-hover: 6px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This offset determines how far away are VDisks when hovered. Example of 16px offset:

Screenshot 2024-12-19 at 13 52 22

@artemmufazalov artemmufazalov added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 640dd97 Dec 19, 2024
7 checks passed
@artemmufazalov artemmufazalov deleted the 667-update-donors-view branch December 19, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

donors on the first row are drawn little higher than the table region
2 participants